1310 modify gasprices storage to support multi asset fees #1412
Conversation
🦋 Changeset detectedLatest commit: 30d7049 The changes in this PR will be included in the next version bump. This PR includes changesets to release 10 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Valentine1898
force-pushed
the
1310-modify-gasprices-storage-to-support-multi-asset-fees
branch
from
44c356a to
557677b
Compare
| await this.indexedDb.saveGasPrices( | ||
| new GasPrices({ | ||
| assetId: this.stakingAssetId, | ||
| ...compactBlock.gasPrices, | ||
| }), | ||
| ); | ||
| } | ||
| if (compactBlock.altGasPrices.length) { | ||
| for (const gasPrice of compactBlock.altGasPrices) { | ||
| await this.indexedDb.saveGasPrices(gasPrice); | ||
| } |
There was a problem hiding this comment.
this suggests that the RPC node is returning information in compact blocks about two alternative gas fees, but with zero gas prices. Manual testing confirmed that all other token denominations result in a "GasPrices not available" error.
| return ( | ||
| umNote.heightSpent === 0n && | ||
| !isZero(getAmountFromRecord(umNote)) && | ||
| umNote.addressIndex?.equals(addressIndex) |
There was a problem hiding this comment.
nice filtering for address index here
| asset_id: alt_gas, | ||
| block_space_price: gas_prices.block_space_price * 10, | ||
| compact_block_space_price: gas_prices.compact_block_space_price * 10, | ||
| verification_price: gas_prices.verification_price * 10, | ||
| execution_price: gas_prices.execution_price * 10, |
There was a problem hiding this comment.
gas fee token price multiplier will instead be determined by governance proposals, rather than arbitrarily setting a 10x multiplier.
Valentine1898
deleted the
1310-modify-gasprices-storage-to-support-multi-asset-fees
branch
Closes #1310
Fixes #1404
Fixes #1397